Repository navigation
ci(deploy): refuse to deploy public source maps - #708
Conversation
Sentry deletes source maps only after it uploads them, and skew storage restores earlier releases' maps into .output/public. A build without the Sentry token, or a silent delete failure, would serve every map again. The deploy now stops after Build, before migrations or any production change, when .output/public holds a map.
|
Agent check (Harlan Agent Kit), run by hand because the step runs only in a production deploy:
|
|
🤖 Harlan Agent Kit Agent assessment of head a492c50. The Service Review was stopped for this head because the Service reported No blocker found (confidence 90/100). Today's deploy would pass the step. Skew storage restores old assets during Logged follow-ups, none above 80:
|
🔗 Linked issue
Follow-up to the logged findings on #705. No GitHub issue.
❓ Type of change
📚 Description
#705 stopped production from serving source maps, but only while Sentry's delete step runs and works. Sentry deletes maps only after it uploads them, and skew storage restores earlier releases' maps into
.output/public. A build withoutSENTRY_AUTH_TOKENdeletes nothing, and the plugin swallowsrmerrors, so either case would publish every map again without a warning.The deploy job now checks
.output/publicright after Build. If any.mapfile remains, it prints the count and the first five paths, then stops before migrations or any production change.